Don't run non-tvm_op GraphRuntime nodes in Debug Runtime over RPC. #7512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* These are filtered out in SetupOpExecs for normal debug runtime operation.
areusch
force-pushed
the
fix-graph-runtime-debug-ops
branch
from
22f28ae to
5145a28
Compare
|
Is this for ops that are extern calls? Like calling into MKL? |
|
@tkonolige no, the GraphRuntime has two different paths to run operators: one for local operators where non-kernel ops could be done fairly inexpensively (I.e. layout transforms maybe? this isn't actually used) and one for RPC operators (where that is not easy). right now tvm_op == "null" (for graph nodes which are inputs) or "tvm_op" (for graph nodes which are operator function execs). |
tkonolige
approved these changes
Feb 25, 2021
|
Thanks @tkonolige @areusch the PR has been merged |
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
…pache#7512) * Don't run non-tvm_op GraphRuntime nodes in Debug Runtime over RPC. * These are filtered out in SetupOpExecs for normal debug runtime operation. * retrigger CI * retrigger CI * address tkonolige comment
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
…pache#7512) * Don't run non-tvm_op GraphRuntime nodes in Debug Runtime over RPC. * These are filtered out in SetupOpExecs for normal debug runtime operation. * retrigger CI * retrigger CI * address tkonolige comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tmoreau89 @tqchen @jroesch @tkonolige