Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACL][TESTING] Use pytest.mark.parametrize in ACL conv2d tests #14011

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

ekalda
Copy link
Contributor

@ekalda ekalda commented Feb 16, 2023

Parametrize the test instead of looping over a long list of configs in the test body.

Parametrize the test instead of looping over a long list of configs
in the test body.
@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 16, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@ekalda
Copy link
Contributor Author

ekalda commented Feb 16, 2023

cc @lhutton1

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ekalda, this is long overdue :)

@lhutton1 lhutton1 changed the title [TESTING] Use pytest.mark.parametrize in ACL conv2d tests [ACL][TESTING] Use pytest.mark.parametrize in ACL conv2d tests Feb 16, 2023
@lhutton1 lhutton1 merged commit 0dd3d4a into apache:main Feb 16, 2023
@lhutton1
Copy link
Contributor

Thanks @ekalda @leandron!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants