Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microNPU] Upgrade Vela to v3.5.0 #13394

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

Aleksei-grovety
Copy link
Contributor

Upgrading Vela version to 3.5.0.
cc @manupa-arm @ekalda @leandron

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 15, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@github-actions github-actions bot requested review from ekalda and leandron November 15, 2022 15:15
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @alexey-yazev

@lhutton1
Copy link
Contributor

lhutton1 commented Nov 16, 2022

@leandron does this also need a CI run to check against the updated docker image?

Edit: pushed a non-forked branch of this commit to trigger CI with the updated docker image

@leandron
Copy link
Contributor

@leandron does this also need a CI run to check against the updated docker image?

Edit: pushed a non-forked branch of this commit to trigger CI with the updated docker image

I think the CI run on the non-forked branch failed for an unrelated reason. In parallel I pushed this change to ci-docker-stage branch for further validation: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/290/pipeline

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation completed for this patch, so I'm happy for this to be merged as soon as CI is green here. Thanks @alexey-yazev @lhutton1

@leandron
Copy link
Contributor

@tvm-bot rerun

@leandron leandron merged commit c1b8721 into apache:main Nov 18, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@Aleksei-grovety Aleksei-grovety deleted the update-vela branch December 22, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants