fix: Scroll to top when selecting a global dashboard tab #28386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
commented
May 8, 2024
| @@ -603,11 +603,6 @@ export function setActiveTab(tabId, prevTabId) { | |||
| return { type: SET_ACTIVE_TAB, tabId, prevTabId }; | |||
| } | |||
|
|
|||
| export const SET_ACTIVE_TABS = 'SET_ACTIVE_TABS'; | |||
| export function setActiveTabs(activeTabs) { | |||
There was a problem hiding this comment.
This was not being referenced anywhere.
rusackas
reviewed
May 8, 2024
| @@ -35,16 +35,4 @@ describe('DashboardState reducer', () => { | |||
| ), | |||
| ).toEqual({ activeTabs: ['tab2'] }); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Is this the test I've seen randomly failing on CI? If so, then die, test!
michael-s-molina
added
the
v4.0
imancrsrk
pushed a commit
to imancrsrk/superset
that referenced
this pull request
May 10, 2024
michael-s-molina
added a commit
that referenced
this pull request
May 13, 2024
(cherry picked from commit 9e4ba67)
9 tasks
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
May 31, 2024
|
This is a great fix - I kept noticing it during my testing 😄 |
mistercrunch
added
🍒 4.0.2
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR changes the dashboard component to scroll to top when a global tab is selected. This is to avoid the situation where a blank dashboard is shown to the user because of the previous tab scroll position. This change does not affect internal tab selections.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2024-05-08.at.11.22.55.mov
Screen.Recording.2024-05-08.at.11.21.39.mov
TESTING INSTRUCTIONS
Check the videos for instructions.
ADDITIONAL INFORMATION