-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(post-processing): handle missing values in cumulative operator #26429
fix(post-processing): handle missing values in cumulative operator #26429
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26429 +/- ##
==========================================
- Coverage 69.16% 69.16% -0.01%
==========================================
Files 1948 1948
Lines 76042 76054 +12
Branches 8493 8493
==========================================
+ Hits 52593 52601 +8
- Misses 21269 21273 +4
Partials 2180 2180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…pache#26429) (cherry picked from commit ff025b7)
SUMMARY
If your data contains nulls, using the cumsum operator will cause gaps in the chart. This is because null values appear as nulls in the series instead of the cumulative value. To avoid this, we replace nulls with zeros before applying the operator, ensuring that all values are present in the series.
AFTER
Now gaps in the data won't cause the bar to be truncated:
BEFORE
Previously, missing values would cause the cumulative series to be missing in the chart, causing gaps in the graph:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION