Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(websocket): [WIP] Making JWT algos configurable #25521

Merged
merged 1 commit into from
Oct 23, 2023
Merged

chore(websocket): [WIP] Making JWT algos configurable #25521

merged 1 commit into from
Oct 23, 2023

Conversation

craig-rueda
Copy link
Member

@craig-rueda craig-rueda commented Oct 4, 2023 •
edited
Loading

SUMMARY

Adds new [optional] config key to websocket server, jwtAlgorithms that allows for multiple algos to be utilized, as defined here: /~https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/jsonwebtoken/index.d.ts#L146

  • Retains the current default of HS256

@craig-rueda craig-rueda requested a review from dpgaspar October 4, 2023 18:04
dpgaspar
dpgaspar approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have tests

@craig-rueda
Copy link
Member Author

would be nice to have tests

There are tests, but this doesn't change functionality, so they continue to pass. I can add an additional test to verify the new codepath

@rusackas rusackas changed the title chore(websocket): Making JWT algos configurable chore(websocket): [WIP] Making JWT algos configurable Oct 17, 2023
@rusackas rusackas added the hold! On hold label Oct 17, 2023
@craig-rueda craig-rueda merged commit 861ee8b into apache:master Oct 23, 2023
@craig-rueda craig-rueda deleted the craig/add-jwt-algos branch October 23, 2023 18:28
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@craig-rueda
chore(websocket): [WIP] Making JWT algos configurable (apache#25521)
c3a398d
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@craig-rueda @sfirke
chore(websocket): [WIP] Making JWT algos configurable (apache#25521)
0fc82a2
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@craig-rueda
chore(websocket): [WIP] Making JWT algos configurable (apache#25521)
c45b441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar dpgaspar approved these changes

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels hold! On hold size/S 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@craig-rueda @betodealmeida @dpgaspar @mistercrunch @rusackas