Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tags Polish II #25496

Merged
merged 5 commits into from
Oct 4, 2023
Merged

fix: Tags Polish II #25496

merged 5 commits into from
Oct 4, 2023

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Oct 3, 2023

SUMMARY

Fixed the following issues brought up by product:

  • When a tag has a long description, it overlaps the other header info:
    • When the tag description is blank, the metadata bar looks incorrect - we can check with Kasia if this isn't already defined in the component
  • all of the metadata bar items are already defined in the code. Description icon should not be visible if it's blank (you can contact Kamil as he knows some details about how it works)
  • Edit Tag button looks not centered in the button:
  • Dropdown heights can be taller, there should be a max height for dropdowns
  • Update text to match mocks header should say Bulk tag charts, Bulk tag dashboards, etc. + Second line should not include "the"
  • Add space between the line of text and tags
  • There should be 16px spacing between the fields (so like between tag name and description)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh merged commit 5301339 into apache:master Oct 4, 2023
@hughhhh hughhhh deleted the tags-polish-2 branch October 4, 2023 00:41
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants