Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Moves Profile to Single Page App (SPA) #25001

Merged
merged 2 commits into from
Aug 17, 2023
Merged

feat: Moves Profile to Single Page App (SPA) #25001

merged 2 commits into from
Aug 17, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Moves the Profile page to SPA
  • Introduces a new endpoint /profile
  • Deprecates and adds a redirect to the old endpoint /superset/profile to preserve backward compatibility
  • Organizes the files using the pages and features folders
  • Removes old entrypoint related files

TESTING INSTRUCTIONS

1 - Make sure the Profile page works as before but in the context of SPA (does not reload the page when navigating)
2 - Make sure that /superset/profile redirects to /profile

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://54.190.195.197:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

justinpark
justinpark approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

villebro
villebro approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE! LGTM and tested to work as expected

@michael-s-molina michael-s-molina merged commit 712e1f7 into apache:master Aug 17, 2023
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@michael-s-molina
feat: Moves Profile to Single Page App (SPA) (apache#25001)
5abfb9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@justinpark justinpark justinpark approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@kgabryje kgabryje Awaiting requested review from kgabryje

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michael-s-molina @justinpark @villebro @mistercrunch