Skip to content

Parent filter is persisting after canceling #17144

Closed
@michael-s-molina

Description

In native filters, the parent filter is persisting after canceling.

@m-ajay @graceguo-supercat @jinghua-qa

How to reproduce the bug

  1. Go to the native filters configuration modal
  2. Set a parent filter
  3. Cancel the changes
  4. Reopen the modal
  5. The parent filter is still there

Expected results

The parent filter is not there anymore after canceling.

Actual results

The parent filter persists after canceling.

Screenshots

Screen.Recording.2021-10-18.at.10.31.20.AM.mov

Environment

  • browser type and version: Chrome 94.0.4606.81
  • superset version: master
  • any feature flags active: NATIVE_FILTERS

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Metadata

Assignees

No one assigned

    Labels

    #bugBug report

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions