SOLR-15579: Re-configure calcite to allow more values in an IN clause #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-15579
Description
See the JIRA
Solution
Override the default
DEFAULT_IN_SUB_QUERY_THRESHOLD
for Calcite'sSqlToRelConverter
to allow more values in an IN clause. Previously using more than 19 would result in the IN clause being ignored, now users are only limited by themaxBooleanClauses
configured for a collection.Tests
Unit test with 200 values in an IN clause. Also cleaned up the NOT + AND/OR query construction logic.
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.