Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish NPE fix in handleMethodException method of apm-jdk-threadpool-plugin #682

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Polish NPE fix in handleMethodException method of apm-jdk-threadpool-plugin #682

merged 1 commit into from
Apr 19, 2024

Conversation

ForrestWang123
Copy link
Contributor

Fix Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.
  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #12128
  • Update the CHANGES log.

@wu-sheng
Copy link
Member

What is the new change about?

@wu-sheng wu-sheng added bug Something isn't working plugin labels Apr 18, 2024
wu-sheng
wu-sheng approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like a polish for the previous PR.

@wu-sheng wu-sheng changed the title Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin Polish NPE fix in handleMethodException method of apm-jdk-threadpool-plugin Apr 19, 2024
@wu-sheng wu-sheng added this to the 9.2.0 milestone Apr 19, 2024
@wu-sheng wu-sheng added the chore label Apr 19, 2024
@wu-sheng wu-sheng merged commit 1a01047 into apache:main Apr 19, 2024
188 checks passed
liweiyuan pushed a commit to liweiyuan/skywalking-java that referenced this pull request Apr 24, 2024
@ForrestWang123 @liweiyuan
Fix NPE in handleMethodException method of apm-jdk-threadpool-plugin. (…
3f21845 
…apache#681) (apache#682)

Co-authored-by: forrestwang <forrest.wang@woo.network>
@wu-sheng wu-sheng modified the milestones: 9.2.0, 9.3.0 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
bug Something isn't working chore plugin
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ForrestWang123 @wu-sheng