-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wqueue remove enter_critical_section #14623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Arch: arm
Issues related to ARM (32-bit) architecture
Arch: arm64
Issues related to ARM64 (64-bit) architecture
Arch: avr
Issues related to all AVR(8-bit or 32-bit) architectures
Arch: ceva
Issues related to CEVA architecture
Arch: hc
Issues related to HC architecture
Arch: mips
Issues related to the MIPS architecture
Arch: openrisc
Issues related to the OpenRISC architecture
Arch: renesas
Issues related to the Renesas chips
Arch: risc-v
Issues related to the RISC-V (32-bit or 64-bit) architecture
Arch: simulator
Issues related to the SIMulator
Arch: sparc
Issues related to the SPARC architecture
Arch: tricore
Issues related to the TriCore architecture from Infineon
Arch: x86
Issues related to the x86 architecture
Arch: x86_64
Issues related to the x86_64 architecture
Arch: xtensa
Issues related to the Xtensa architecture
Arch: z16
Issues related to the Z16 architecture
Arch: z80
Issues related to the Z80 architecture
Area: File System
File System issues
Area: OS Components
OS Components issues
Size: L
The size of the change in this PR is large
labels
Nov 4, 2024
github-actions
bot
removed
Arch: arm
Issues related to ARM (32-bit) architecture
Arch: arm64
Issues related to ARM64 (64-bit) architecture
Arch: avr
Issues related to all AVR(8-bit or 32-bit) architectures
Arch: ceva
Issues related to CEVA architecture
Arch: hc
Issues related to HC architecture
Arch: mips
Issues related to the MIPS architecture
Arch: openrisc
Issues related to the OpenRISC architecture
Arch: renesas
Issues related to the Renesas chips
labels
Nov 4, 2024
1 task
acassis
reviewed
Nov 5, 2024
Note that some places said work_cancel() only returns success, these comments need to be fixed. i.e.:
|
github-actions
bot
added
Arch: arm
Issues related to ARM (32-bit) architecture
Area: File System
File System issues
labels
Nov 6, 2024
This PR requires #14578 to be merged first. |
@hujun260 many comments aren't addressed in the new reversion yet. |
hujun260
force-pushed
the
apache_8
branch
3 times, most recently
from
January 12, 2025 05:50
45c5016
to
cc2f64b
Compare
hujun260
force-pushed
the
apache_8
branch
2 times, most recently
from
January 14, 2025 01:09
d3376ae
to
e74c6b7
Compare
reason: We decouple semcount from business logic by using an independent counting variable, which allows us to remove critical sections in many cases. Signed-off-by: hujun5 <hujun5@xiaomi.com>
xiaoxiang781216
approved these changes
Jan 15, 2025
hujun260
added a commit
to hujun260/nuttx
that referenced
this pull request
Jan 17, 2025
reason: work_timer_expiry may be called in thread context Signed-off-by: hujun5 <hujun5@xiaomi.com>
xiaoxiang781216
pushed a commit
that referenced
this pull request
Jan 17, 2025
reason: work_timer_expiry may be called in thread context Signed-off-by: hujun5 <hujun5@xiaomi.com>
SPRESENSE
added a commit
to SPRESENSE/nuttx
that referenced
this pull request
Jan 17, 2025
* apache/nuttx/master: arch/armv7-r: fix gic.h build error sim: fix regression from apache#14623 arch/Kconfig: allow FLASH config for non-MMU chips nuttx: add open and close callback functions for the mouse. nuttx: Open mouse/touch/keyboard options can be configured nuttx: Support for rpmsgdev custom ioctl nuttx: Support for the mouse ioctl interface sensors/sht4x: Converted SHT4X driver to UORB framework. Add GD55 QSPI NOR Flash support sensors/msxxxx-crc4: Modify CRC calculation so that it passes with MS5611. sched/wqueue: fix potential deadlock sched/wdog: remove wd_cancel_irq() implement risc-v: replace fence.i with __ISB for instruction sync libc/gnssutils: remove C99 standard flag from Make.defs libs/lib_tempbuffer: set `errno` when fails Add uid file needed for ethernet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Arch: arm
Issues related to ARM (32-bit) architecture
Area: File System
File System issues
Area: OS Components
OS Components issues
Size: M
The size of the change in this PR is medium
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
work queue
Testing
Build Host:
OS: Ubuntu 20.04
CPU: x86_64
Compiler: GCC 9.4.0
Configuring NuttX and compile:
$ ./tools/configure.sh -l qemu-armv8a:nsh_smp
$ make
Running with qemu
$ qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic
-machine virt,virtualization=on,gic-version=3
-net none -chardev stdio,id=con,mux=on -serial chardev:con
-mon chardev=con,mode=readline -kernel ./nuttx