Add support for GlassFish 7 up to 7.0.21, and GlassFish 8 up to 8.0.0-M9 #8153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlassFish 8.0.0-M9
pepness
added
Java EE/Jakarta EE
matthiasblaesing
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
For the future I don't think these changes are necessary. They don't test the version, just the eh operators work. That is independend on newer versions.
| * <p/> | ||
| * Factory should initialize REST {@code Runner} and point it to | ||
| * provided {@code Command} instance. | ||
| */ | ||
| @Test | ||
| public void testGetInstanceforVersionGF7() { | ||
| GlassFishServerEntity srv = new GlassFishServerEntity(); | ||
| srv.setVersion(GlassFishVersion.GF_7_0_15); | ||
| srv.setVersion(GlassFishVersion.GF_7_0_21); |
There was a problem hiding this comment.
What is the intention of this change?
There was a problem hiding this comment.
Those test are helpful in my pipeline, sometimes I messed up ServerDetails, registering the wrong ConfigBuilderProvider or even working on a different branch. I always run the unit test for the 4 GlassFish modules using the latest version that I add support to. That is why I always change the version of the unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetBeans GlassFish module notes:
NetBeans Testing:
glassfish.common,glassfish.javaee,glassfish.tooling, andglassfish.eecommonRelease Notes for GlassFish 7
Release Notes for GlassFish 8