Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the few remaining HashSet warnings. #8147

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

BradWalker
Copy link
Member

Cleanup the few remaining HashSet warnings.. Reduce warnings that look like this:

[repeat] /home/bwalker/src/netbeans/enterprise/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerInstance.java:144: warning: [rawtypes] found raw type: HashSet
[repeat] private final Set targetsStartedByIde = new HashSet(); // valued by target name
[repeat] ^
[repeat] missing type arguments for generic class HashSet
[repeat] where E is a type-variable:
[repeat] E extends Object declared in class HashSet


^Add meaningful description above

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

Reduce warnings that look like this:

   [repeat] /home/bwalker/src/netbeans/enterprise/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerInstance.java:144: warning: [rawtypes] found raw type: HashSet
   [repeat]     private final Set<String> targetsStartedByIde = new HashSet(); // valued by target name
   [repeat]                                                         ^
   [repeat]   missing type arguments for generic class HashSet<E>
   [repeat]   where E is a type-variable:
   [repeat]     E extends Object declared in class HashSet
@BradWalker BradWalker added this to the NB25 milestone Jan 13, 2025
@BradWalker BradWalker self-assigned this Jan 13, 2025
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Please fix your name in the author commit header. One can read you real name from it, but it still should be just a full name.

@mbien
Copy link
Member

mbien commented Jan 13, 2025

git shortlog -se | grep Brad

has 4 variants and the one without space is already there, so its probably fine ;) (but you should fix it anyway!)

@BradWalker BradWalker merged commit 1057945 into apache:master Jan 14, 2025
30 of 31 checks passed
@BradWalker BradWalker deleted the cleanup_hashset_warnings branch January 14, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants