Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] Prevent NPE for mark occurrences #8070

Merged
merged 1 commit into from
Dec 18, 2024
Merged

[PHP] Prevent NPE for mark occurrences #8070

merged 1 commit into from
Dec 18, 2024

Conversation

junichi11
Copy link
Member

  • Add null check because it may be null when the mark occurrences feature is canceled

My consideration was missing, sorry.

@junichi11
Prevent NPE
94c111a 
- Add `null` check because it may be `null` when the mark occurrences feature is canceled
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Dec 18, 2024
@junichi11 junichi11 added this to the NB25 milestone Dec 18, 2024
@junichi11 junichi11 requested a review from tmysik December 18, 2024 03:56
@junichi11 junichi11 merged commit 8a420a7 into apache:master Dec 18, 2024
32 checks passed
@junichi11 junichi11 deleted the php-fix-npe branch December 18, 2024 05:59
@mbien mbien mentioned this pull request Dec 20, 2024
Merged
@junichi11 junichi11 changed the title Prevent NPE [PHP] Prevent NPE for mark occurrences Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmysik tmysik tmysik approved these changes

Assignees
No one assigned
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB25
Development

Successfully merging this pull request may close these issues.
2 participants
@junichi11 @tmysik