Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement subword completion for SQL editor #7945

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

matthiasblaesing
Copy link
Contributor

Closes: #7912

@matthiasblaesing matthiasblaesing added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Nov 8, 2024
@matthiasblaesing matthiasblaesing added this to the NB25 milestone Nov 8, 2024
@mbien mbien added the SQL label Nov 18, 2024
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me

@matthiasblaesing
Copy link
Contributor Author

@mbien thanks for review, @vulewuxe86 thanks for testing

@matthiasblaesing matthiasblaesing merged commit 41483e9 into apache:master Nov 21, 2024
31 checks passed
@matthiasblaesing matthiasblaesing deleted the subword_completion branch November 30, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) SQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subword completion for SQL
2 participants