Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] License updates per ASF feedback #20377

Merged
merged 5 commits into from
Jun 24, 2021
Merged

[v1.x] License updates per ASF feedback #20377

merged 5 commits into from
Jun 24, 2021

Conversation

josephevans
Copy link
Contributor

Address licensing concerns raised by our IPMC mentors:

  1. Do not distribute 3rdparty/googletest/ci in source archive
  2. Do not distribute docs/*** in source archive
  3. Remove references to docs in LICENSE that are no longer distributed in source archive
  4. Clarify include/mkldnn in LICENSE
  5. Remove SIL open font license from licenses/ and reference in LICENSE

@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, windows-cpu, unix-cpu, website, clang, centos-gpu, sanity, edge, windows-gpu, miscellaneous, unix-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Jun 23, 2021
leezu
leezu reviewed Jun 23, 2021
View reviewed changes
tools/source-exclude-artifacts.txt
@@ -22,3 +22,5 @@

R-package
3rdparty/mkldnn/doc
3rdparty/googletest/ci
docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs folder also contains the install instructions (build_from_source page)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think most users building from source are following instructions from a web site, not viewing them from the source tree (after all, they are in .md format and would require viewing through a formatter/browser.) Do you think it's a requirement to ship them out in the source archive though?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a requirement, but it's not ideal as the website may change over time, while the archive remains fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but the git version tag will always be there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think at least a link to the install instructions is needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you or have you heard anyone use the docs inside the release package?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josephevans Can we only keep the install instructions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you mean the build instructions, they are in /~https://github.com/apache/incubator-mxnet/blob/v1.x/docs/static_site/src/pages/get_started/build_from_source.md - we could copy this file to the root source archive. Alternatively, we could create a README.txt file with a link to the instructions on the web-site (but the latest version would have to be published.)

samskalicky
samskalicky approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@samskalicky samskalicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @josephevans

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jun 23, 2021
ChaiBapchya
ChaiBapchya approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ptrendx
Copy link
Member

ptrendx commented Jun 23, 2021

Removing entire docs directory just because of few fonts seems like quite a heavy handed approach. Could we instead just download those fonts as part of docs CD pipeline?

@josephevans
Copy link
Contributor Author

Removing entire docs directory just because of few fonts seems like quite a heavy handed approach. Could we instead just download those fonts as part of docs CD pipeline?

I agree that it's a fairly drastic change, but I am not convinced many users actually use the docs from the source archive. It takes a bit of effort to get them built and requires viewing them through a browser, and I would bet most people don't go through this effort and just use the documentation online.

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jun 23, 2021
@josephevans josephevans force-pushed the v1.x_license_updates branch from f929c54 to df4a0ab Compare June 24, 2021 02:00
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 24, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 24, 2021
@samskalicky samskalicky merged commit 6a02a27 into apache:v1.x Jun 24, 2021
josephevans added a commit to josephevans/mxnet that referenced this pull request Jun 24, 2021
@josephevans @szha
[v1.x] License updates per ASF feedback (apache#20377)
447a1e8 
* switch to DISCLAIMER (apache#20242)

Signed-off-by: Sheng Zha <zhasheng@amazon.com>

* Don't distribute 3rdparty/googletest/ci in source archive.

* Add reference in LICENSE to symlinks in include/mkldnn that point to 3rdparty/mkldnn.

* Do not distribute docs/ subdir in source archive.

* Remove references to docs from LICENSE (since they are no longer distributed in source archive,) and remove SIL open font license and reference in LICENSE.

Co-authored-by: Sheng Zha <szha@users.noreply.github.com>
Co-authored-by: Joe Evans <joeev@amazon.com>
josephevans added a commit to josephevans/mxnet that referenced this pull request Jun 24, 2021
@josephevans @szha
[v1.x] License updates per ASF feedback (apache#20377)
34fd110 
* switch to DISCLAIMER (apache#20242)

Signed-off-by: Sheng Zha <zhasheng@amazon.com>

* Don't distribute 3rdparty/googletest/ci in source archive.

* Add reference in LICENSE to symlinks in include/mkldnn that point to 3rdparty/mkldnn.

* Do not distribute docs/ subdir in source archive.

* Remove references to docs from LICENSE (since they are no longer distributed in source archive,) and remove SIL open font license and reference in LICENSE.

Co-authored-by: Sheng Zha <szha@users.noreply.github.com>
Co-authored-by: Joe Evans <joeev@amazon.com>
@josephevans josephevans deleted the v1.x_license_updates branch June 24, 2021 21:25
Zha0q1 pushed a commit that referenced this pull request Jun 29, 2021
@josephevans @szha
[v1.9.x] Backport - License updates per ASF feedback (#20377) (#20386)
d0c2a94 
* [v1.x] License updates per ASF feedback (#20377)

* switch to DISCLAIMER (#20242)

Signed-off-by: Sheng Zha <zhasheng@amazon.com>

* Don't distribute 3rdparty/googletest/ci in source archive.

* Add reference in LICENSE to symlinks in include/mkldnn that point to 3rdparty/mkldnn.

* Do not distribute docs/ subdir in source archive.

* Remove references to docs from LICENSE (since they are no longer distributed in source archive,) and remove SIL open font license and reference in LICENSE.

Co-authored-by: Sheng Zha <szha@users.noreply.github.com>
Co-authored-by: Joe Evans <joeev@amazon.com>

* Merge in Zhaoqi's ONNX license changes.

Co-authored-by: Sheng Zha <szha@users.noreply.github.com>
Co-authored-by: Joe Evans <joeev@amazon.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 left review comments

@TristonC TristonC TristonC left review comments

@leezu leezu leezu left review comments

@ChaiBapchya ChaiBapchya ChaiBapchya approved these changes

@Kh4L Kh4L Kh4L approved these changes

@samskalicky samskalicky samskalicky approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.