Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix reshape interoperability test #17155

Merged
merged 2 commits into from
Dec 25, 2019
Merged

Fix reshape interoperability test #17155

merged 2 commits into from
Dec 25, 2019

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Dec 23, 2019

Description

Fix for #17154

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@haojin2 haojin2 added the Numpy label Dec 23, 2019
@haojin2 haojin2 requested a review from leezu December 23, 2019 14:12
@haojin2 haojin2 self-assigned this Dec 23, 2019
@haojin2 haojin2 requested a review from reminisce December 23, 2019 14:12
@haojin2 haojin2 mentioned this pull request Dec 23, 2019
Closed
@haojin2 haojin2 force-pushed the fix_reshape_interoperability branch from 13429a0 to 96180ac Compare December 25, 2019 02:39
@haojin2 haojin2 force-pushed the fix_reshape_interoperability branch 2 times, most recently from a87887e to a4efc1c Compare December 25, 2019 03:33
@haojin2 haojin2 force-pushed the fix_reshape_interoperability branch from a4efc1c to 6b42da0 Compare December 25, 2019 05:36
xidulu
xidulu approved these changes Dec 25, 2019
View reviewed changes
Copy link
Contributor

@xidulu xidulu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(For god sake plz merge this PR ASAP

@yajiedesign
Copy link
Contributor

LGTM

@haojin2 haojin2 merged commit 318d9c7 into apache:master Dec 25, 2019
leezu pushed a commit to leezu/mxnet that referenced this pull request Dec 30, 2019
@haojin2 @leezu
Fix reshape interoperability test (apache#17155)
3be659f 
* fix reshape interoperability test

* fix for scipy import
@leezu leezu mentioned this pull request Dec 30, 2019
Merged
leezu added a commit that referenced this pull request Dec 30, 2019
@leezu @cjolivier01 @haojin2
Backport 3rdparty/openmp fixes (#17193)
80a850d 
* Upgrade 3rdparty/openmp to release_90 version (#17012)

Fixes #10856

* Fix omp assert issue (#17039)

* Disable OpenMP offloading support for 3rdparty/openmp (#17098)

* Disable OpenMP offloading support for 3rdparty/openmp

OpenMP offloading was introduced some time during the past two years and is
enabled by default. With upgrading 3rdparty/openmp in
#17012
it was made part of the MXNet CMake build.

But we don't use OpenMP offloading and the Cuda target in the llvm OpenMP
Offloading build is broken in our setting.

* Update CMake on CI

* Fix reshape interoperability test (#17155)

* fix reshape interoperability test

* fix for scipy import

Co-authored-by: Chris Olivier <cjolivier01@gmail.com>
Co-authored-by: Hao Jin <hjjn.amzn@gmail.com>
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Jan 16, 2020
@haojin2 @ChaiBapchya
Fix reshape interoperability test (apache#17155)
c4597f7 
* fix reshape interoperability test

* fix for scipy import
@haojin2 haojin2 deleted the fix_reshape_interoperability branch January 16, 2020 19:40
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Jan 16, 2020
@haojin2 @ChaiBapchya
Fix reshape interoperability test (apache#17155)
8407f93 
* fix reshape interoperability test

* fix for scipy import
ChaiBapchya added a commit to ChaiBapchya/mxnet that referenced this pull request Jan 16, 2020
@ChaiBapchya
Revert "Fix reshape interoperability test (apache#17155)"
1794aef 
This reverts commit 8407f93.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xidulu xidulu xidulu approved these changes

@leezu leezu Awaiting requested review from leezu

@reminisce reminisce Awaiting requested review from reminisce

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees

@haojin2 haojin2

Labels
Numpy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haojin2 @yajiedesign @xidulu