This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[API] unified API for custom kvstores #17010
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-haibin-lin
requested review from
aaronmarkham and
marcoabreu
as code owners
December 8, 2019 06:56
@ChaokunChang FYI |
apeforest
reviewed
Dec 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does the API look like for Horovod? Could you please add some interface for Horovod related APIs so we know if the design of class is sufficient.
Thanks for the detailed review comments. Just updated the PR. |
apeforest
approved these changes
Dec 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Using a base KVStore class simplies the implementation in Training class, although the method pushpull naming seems to indicate a PS-based strategy. It might be a good idea to add an alias like allreduce for non PS strategies.
This was referenced Dec 18, 2019
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
depends on #17007
#16795
See the
KVStoreBase
for all interfaces defined inkvstore/base.py
. SeeTestStore
class in the same file as an example of custom single node kvstore which implements minimal required interfaces.The interfaces include:
We can reuse these interfaces for other communication backends such as p3 and horovod. @anandj91 @apeforest
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Added test for:
test_kvstore_custom.py
test_kvstore_custom.py
test_gluon_trainer.py
Comments