Silence excessive mkldnn logging output on tests. #14947
Conversation
| @@ -553,8 +553,9 @@ void OpCheck::Run(mxnet::FCompute fn, const nnvm::NodeAttrs &attrs, | |||
| for (size_t i = 0; i < out_blobs.size(); i++) | |||
| out_blobs[i] = outputs[i].data(); | |||
| fn(attrs, ctx, in_blobs, req, out_blobs); | |||
|
|
|||
| #ifndef NDEBUG | |||
There was a problem hiding this comment.
Thank you for fixing this. How about changing to check the environmental variable MXNET_MKLDNN_DEBUG? We used this variable in other places.
There was a problem hiding this comment.
@TaoLv sure, will do that.
There was a problem hiding this comment.
Thank you @larroy . We're thinking about adding verbose levels to MXNET_MKLDNN_DEBUG in the future.
|
@pengzhao-intel I saw this excessive log output and had a 3h timeout on tests, wanted to see if the PR validation time goes down because of this, probably not related. |
|
@larroy Sorry just notice that you're trying to save time of CI? I remember |
How about turning it off because we have enough test cases in the CI for MKLDNN now? |
|
Thank you for your improvement. Merge now. |
* Silence excessive mkldnn logging output on tests. http://jenkins.mxnet-ci.amazon-ml.com/blue/rest/organizations/jenkins/pipelines/mxnet-validation/pipelines/unix-cpu/branches/PR-14940/runs/1/nodes/283/steps/749/log/?start=0 * As per Peng Zhao and Tao Lv suggestion
Description
Silenced excessive logging output:
http://jenkins.mxnet-ci.amazon-ml.com/blue/rest/organizations/jenkins/pipelines/mxnet-validation/pipelines/unix-cpu/branches/PR-14940/runs/1/nodes/283/steps/749/log/?start=0
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.