-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[clojure][generator] ndarray/symbol api random merged #14800
[clojure][generator] ndarray/symbol api random merged #14800
Conversation
* `ndarray_random_api` * `symbol_random_api`
@@ -0,0 +1,95 @@ | |||
(ns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to have this file checked in? - it looks like it is written to during the generator test to compare contents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooooops! Good catch! I will remove them
@@ -0,0 +1,118 @@ | |||
(ns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question - Do we need to have this file checked in? - it looks like it is written to during the generator test to compare contents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same answer! Ooooops!
Overall looks fantastic! What a great addition :) Just a couple questions on the inclusion of some test files |
sorry merged by mistake |
This reverts commit 5dd9fa2.
@Chouffe - Actually instead of reverting it, I'll just open a new PR with those two file removed, Since everything else is good |
* [clojure][generator] add random namespace generation * `ndarray_random_api` * `symbol_random_api` * fix tests
* [clojure][generator] add random namespace generation * `ndarray_random_api` * `symbol_random_api` * fix tests
Reopened from PR #14750
Description
Split random functions in their own generated namespace.
ndarray_random_api
symbol_random_api
It renames the following functions to be as close as possible to the scala names:
-random-randint
intorandint
sample-randint
intorandint-like
for instance and put them underndarray-random-api
namespace.TODO
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments