This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Deprecate NDArrayCollector and instead use ResourceScope #14780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR now removes all usages of NDArrayCollector throughout the code and deprecates it as of the 1.5.0 release.
It also updates the ResourceScope to recursively move NDArrays to outer scope when in hierarchical structure of Traversables (list, set, map, etc.) and Products (tuples). It adds a method to check if the ResourceScope contains a value and fixes a bug where moveToOuterScope would move a value to the outer scope despite it not being in the inner scope in the first place.
This contains additions originally part of #14666 that were split out.
@lanking520 @andrewfayres @nswamy
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.