-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
@szha @eric-haibin-lin is there any reason that the gperf is ON by default? |
cc @lebeg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I also met the issue about GPERFTOOLS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will merge in 24 hours if there are no further comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it was decided by an individual as there is significant performance benefit in using alternative malloc. It wasn't thoroughly evaluated and I actually noticed similar issues with tcmalloc, so I'm actually surprised that this is on by default in cmake.
Merging now since the BOSS agree :) |
An "individual" by himself/herself cannot make decisions in an apache incubating project. |
Interesting theory szha, although also incorrect. But disable if you want. Jemalloc is faster most of the time anyway. |
@cjolivier01 thanks for stepping in. I'd like to hear what you would like clairfy and what option you recommend? |
Description
Because of #8968, mxnet will random crash after USE_GPERFTOOLS = 1. Some end-user may get trouble if gperf-tools is pre-installed. So before fix this, we'd better to disable it by default.
@pengzhao-intel @szha
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments