Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Dependency Update]Update the numpy version #14588

Merged
merged 10 commits into from
May 21, 2019
Merged

[Dependency Update]Update the numpy version #14588

merged 10 commits into from
May 21, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Apr 1, 2019 •
edited
Loading

Description

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

disable several pylint comparison-with-callable on event_handler @roywei please check it

@stu1130 stu1130 requested a review from szha as a code owner April 1, 2019 23:50
@piyushghai
Copy link
Contributor

@stu1130 Seems like not all the CI passed on this PR.
Would you be taking a look into the failures ?

@mxnet-label-bot Add [Numpy, pr-work-in-progress]

@marcoabreu marcoabreu added Numpy pr-work-in-progress PR is still work in progress labels Apr 2, 2019
@stu1130 stu1130 force-pushed the upgrade_numpy branch 2 times, most recently from 354d8f2 to 18346b2 Compare April 3, 2019 19:14
@stu1130 stu1130 changed the title [DO NOT MERGE] update the numpy version [WIP] Update the numpy version Apr 4, 2019
@stu1130 stu1130 changed the title [WIP] Update the numpy version Update the numpy version Apr 5, 2019
@stu1130 stu1130 changed the title Update the numpy version [DO NOT MERGE] Update the numpy version Apr 11, 2019
@Roshrini
Copy link
Member

@stu1130 Can you take a look at CI failure.

@stu1130 stu1130 mentioned this pull request Apr 26, 2019
Merged
1 task
@stu1130 stu1130 changed the title [DO NOT MERGE] Update the numpy version [Dependency Update]Update the numpy version May 2, 2019
@stu1130 stu1130 changed the title [Dependency Update]Update the numpy version [WIP][Dependency Update]Update the numpy version May 4, 2019
@stu1130 stu1130 changed the title [WIP][Dependency Update]Update the numpy version [Dependency Update]Update the numpy version May 8, 2019
@stu1130
Copy link
Contributor Author

stu1130 commented May 8, 2019

@szha the PR is ready for review

@stu1130
Copy link
Contributor Author

stu1130 commented May 8, 2019

@mxnet-label-bot Update [Numpy, pr-awaiting-review]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress labels May 8, 2019
@stu1130 stu1130 mentioned this pull request May 15, 2019
Closed
@stu1130 stu1130 force-pushed the upgrade_numpy branch 4 times, most recently from 828ce1a to 9ace9d1 Compare May 18, 2019 05:49
@stu1130
Copy link
Contributor Author

stu1130 commented May 18, 2019

ping @szha for review thanks

szha
szha reviewed May 18, 2019
View reviewed changes
tools/pip/setup.py Outdated Show resolved Hide resolved
wkcn
wkcn approved these changes May 19, 2019
View reviewed changes
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@stu1130 stu1130 force-pushed the upgrade_numpy branch 3 times, most recently from a3cf0f8 to 27dbcad Compare May 20, 2019 19:32
@stu1130 stu1130 closed this May 20, 2019
@stu1130 stu1130 reopened this May 20, 2019
roywei
roywei approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@roywei roywei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for fixing the event handler part

@wkcn wkcn added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels May 21, 2019
@szha szha merged commit 2e827ab into apache:master May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha left review comments

@roywei roywei roywei approved these changes

@wkcn wkcn wkcn approved these changes

Assignees
No one assigned
Labels
Numpy pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@stu1130 @piyushghai @Roshrini @szha @wkcn @roywei @marcoabreu