This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix aspect ratio sampling for RandomResizedCrop #14585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhreshold @szha Could you have a look? @mxnet-label-bot add [pr-awaiting-review] |
|
Thanks for your contribution, would you mind adding a test case for this situation? |
|
@marcoabreu added test in test_image.py |
marcoabreu
approved these changes
Apr 1, 2019
|
@abhinavs95 Can you look into the CI-failures ? |
zhreshold
reviewed
Apr 2, 2019
python/mxnet/image/image.py
Outdated
| @@ -585,14 +586,12 @@ def random_size_crop(src, size, area, ratio, interp=2, **kwargs): | |||
| area = (area, 1.0) | |||
| for _ in range(10): | |||
| target_area = random.uniform(area[0], area[1]) * src_area | |||
| new_ratio = random.uniform(*ratio) | |||
| log_ratio = (math.log(ratio[0]), math.log(ratio[1])) | |||
There was a problem hiding this comment.
you don't need to import math, use np which is already imported
|
@szha could you have a look and merge? Thanks @mxnet-label-bot update [pr-awaiting-merge] |
marcoabreu
added
pr-awaiting-merge
wkcn
approved these changes
Apr 7, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* added log sampling for aspect ratio * added test * added comments * fix test * remove math, fix test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14505
Aspect ratio goes out of bounds when the bounds are not reciprocals. Fixed by sampling from log scale instead of linear scale. When sampling from log scale, random swapping of width/height is not required since the distribution is centered at 1.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.