This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fixes test_operator_gpu.test_multinomial_generator #14475
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu1130
force-pushed
the
fix_multinomial
branch
from
March 20, 2019 16:11
243d4d2
to
0f64b09
Compare
@mxnet-label-bot add[Test, pr-awaiting-merge] |
marcoabreu
added
pr-awaiting-merge
Review and CI is complete. Ready to Merge
Test
labels
Mar 20, 2019
apeforest
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you add a comment in the code that this success_rate might make the tests flaky. Please also refer to the issue number in your comment. |
Merged. Thanks for your contribution! |
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* adjust the success rate * add comments
ZhennanQin
pushed a commit
to ZhennanQin/incubator-mxnet
that referenced
this pull request
Apr 3, 2019
* adjust the success rate * add comments
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
* adjust the success rate * add comments
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* adjust the success rate * add comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14457, Fixes #14158
success_rate of the verify_generator function was changing from 0.15 to 0.25 after the this #13498. Since then the test became flaky. Reassign the success_rate to 0.2.
Run 9606 times pass the test.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments