This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-1226] add Docs update for MXNet Java #14395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronmarkham
suggested changes
Mar 12, 2019
| @@ -35,21 +35,15 @@ The following instructions are provided for macOS and Ubuntu. Windows is not yet | |||
| brew update | |||
| brew tap caskroom/versions | |||
| brew cask install java8 | |||
| brew install opencv | |||
There was a problem hiding this comment.
What's going on here?
There was a problem hiding this comment.
We don't need to install openCV for Java, not any more
|
|
||
| ```bash | ||
| wget https://raw.githubusercontent.com/apache/incubator-mxnet/master/ci/docker/install/ubuntu_core.sh |
There was a problem hiding this comment.
So all of the dependencies for ubuntu/scala/mxnet environment are covered with this change? I'm skeptical.
There was a problem hiding this comment.
We no longer require user to install that bunch... Simply Java and maven would work
|
@mxnet-label-bot add [Java, Doc] |
zachgk
reviewed
Mar 12, 2019
Co-Authored-By: lanking520 <lanking520@live.com>
Co-Authored-By: lanking520 <lanking520@live.com>
zachgk
approved these changes
Mar 13, 2019
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* add Docs update for MXNet Java * fixed based on comments * Update docs/install/java_setup.md Co-Authored-By: lanking520 <lanking520@live.com> * Update docs/tutorials/java/mxnet_java_on_intellij.md Co-Authored-By: lanking520 <lanking520@live.com>
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
* add Docs update for MXNet Java * fixed based on comments * Update docs/install/java_setup.md Co-Authored-By: lanking520 <lanking520@live.com> * Update docs/tutorials/java/mxnet_java_on_intellij.md Co-Authored-By: lanking520 <lanking520@live.com>
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* add Docs update for MXNet Java * fixed based on comments * Update docs/install/java_setup.md Co-Authored-By: lanking520 <lanking520@live.com> * Update docs/tutorials/java/mxnet_java_on_intellij.md Co-Authored-By: lanking520 <lanking520@live.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Java docs update with 1.4.0
@piyushghai @andrewfayres @aaronmarkham
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.