Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

CI Changes for Codified Windows AMIs #14336

Merged
merged 3 commits into from
Mar 11, 2019
Merged

CI Changes for Codified Windows AMIs #14336

merged 3 commits into from
Mar 11, 2019

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Mar 5, 2019 •
edited
Loading

Description

Fixes to re-enable Windows tests
Copy of #14336 - Taking over during his vacation

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@perdasilva perdasilva mentioned this pull request Mar 5, 2019
Closed
5 tasks
@perdasilva perdasilva force-pushed the silvaper-windows-test-paths branch from 5c6c5f3 to 52ff035 Compare March 5, 2019 15:23
@perdasilva perdasilva changed the title [WIP] CI Changes for Codified Windows AMIs CI Changes for Codified Windows AMIs Mar 5, 2019
@vandanavk
Copy link
Contributor

@mxnet-label-bot add [CI, Windows, pr-awaiting-review]

@marcoabreu marcoabreu added CI pr-awaiting-review PR is waiting for code review Windows labels Mar 5, 2019
@perdasilva perdasilva force-pushed the silvaper-windows-test-paths branch 2 times, most recently from 294181c to eaa2b63 Compare March 6, 2019 16:58
@perdasilva
Copy link
Contributor Author

perdasilva commented Mar 7, 2019 •
edited
Loading

Please don't merge yet - moving qemu changes to its own PR (#14355 )

@perdasilva perdasilva force-pushed the silvaper-windows-test-paths branch 2 times, most recently from d31f0c6 to ac9b59b Compare March 8, 2019 07:34
@perdasilva perdasilva mentioned this pull request Mar 8, 2019
Closed
@perdasilva
Copy link
Contributor Author

Need to disabling test_operator_gpu.test_bulking (#14368). It's a new test, that hasn't been through the windows pipeline, which is now failing.

@perdasilva perdasilva force-pushed the silvaper-windows-test-paths branch from ca891cf to 945d112 Compare March 10, 2019 19:16
@perdasilva
Copy link
Contributor Author

@marcoabreu please review and merge if it's ok. Thank you!

@marcoabreu marcoabreu merged commit 0e8c270 into apache:master Mar 11, 2019
@perdasilva perdasilva deleted the silvaper-windows-test-paths branch March 11, 2019 09:49
perdasilva added a commit to perdasilva/incubator-mxnet that referenced this pull request Mar 13, 2019
@perdasilva
CI Changes for Codified Windows AMIs (apache#14336)
fb33f59 
* Change the paths of windows tests to match new AMIs

* Re-enable windows jenkins steps

* Disables test_operator_gpu.test_bulking test
perdasilva added a commit to perdasilva/incubator-mxnet that referenced this pull request Mar 13, 2019
@perdasilva
CI Changes for Codified Windows AMIs (apache#14336)
6324ccc 
* Change the paths of windows tests to match new AMIs

* Re-enable windows jenkins steps

* Disables test_operator_gpu.test_bulking test
perdasilva added a commit to perdasilva/incubator-mxnet that referenced this pull request Mar 13, 2019
@perdasilva
CI Changes for Codified Windows AMIs (apache#14336)
0cc5634 
* Change the paths of windows tests to match new AMIs

* Re-enable windows jenkins steps

* Disables test_operator_gpu.test_bulking test
@perdasilva perdasilva mentioned this pull request Mar 14, 2019
Merged
5 tasks
perdasilva added a commit to perdasilva/incubator-mxnet that referenced this pull request Mar 19, 2019
@perdasilva
Cherry-picks changes from apache#14336 to fix window ci pipeline
683e66a
perdasilva added a commit to perdasilva/incubator-mxnet that referenced this pull request Mar 19, 2019
@perdasilva
Cherry-picks changes from apache#14336 to fix window ci pipeline
42778c5
perdasilva added a commit to perdasilva/incubator-mxnet that referenced this pull request Mar 19, 2019
@perdasilva
Cherry-picks changes from apache#14336 to fix window ci pipeline
43829ca
@perdasilva perdasilva mentioned this pull request Mar 19, 2019
Merged
lanking520 pushed a commit that referenced this pull request Mar 19, 2019
@perdasilva @lanking520
Cherry-picks changes from #14336 to fix window ci pipeline (#14469)
1fed192
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@perdasilva @vdantu
CI Changes for Codified Windows AMIs (apache#14336)
774ae4d 
* Change the paths of windows tests to match new AMIs

* Re-enable windows jenkins steps

* Disables test_operator_gpu.test_bulking test
nswamy pushed a commit that referenced this pull request Apr 5, 2019
@perdasilva @nswamy
CI Changes for Codified Windows AMIs (#14336)
19f05b0 
* Change the paths of windows tests to match new AMIs

* Re-enable windows jenkins steps

* Disables test_operator_gpu.test_bulking test
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@perdasilva
CI Changes for Codified Windows AMIs (apache#14336)
1919359 
* Change the paths of windows tests to match new AMIs

* Re-enable windows jenkins steps

* Disables test_operator_gpu.test_bulking test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcoabreu marcoabreu marcoabreu approved these changes

Assignees
No one assigned
Labels
CI pr-awaiting-review PR is waiting for code review Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perdasilva @vandanavk @marcoabreu