Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Enhance PartitionGraph #14277

Merged
merged 17 commits into from
Mar 26, 2019
Merged

Enhance PartitionGraph #14277

merged 17 commits into from
Mar 26, 2019

Conversation

ZhennanQin
Copy link
Contributor

Description

Extracted from #14113. This PR covers:

  • Add inference_only attr support when SubgraphProperty is created to indicate that this pass should be used for inference only.
  • Allow registering multiple subgraph pass within same backend names.
  • Refactor the way to run PartitionGraph in simple bind stage to ensure any graph nodes reordering can be correctly handled.

This PR is the full version of #14276.
@xinyu-intel @pengzhao-intel @TaoLv @reminisce @zheng-da

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@anirudhacharya
Copy link
Member

anirudhacharya commented Mar 1, 2019 •
edited
Loading

@mxnet-label-bot add [pr-awaiting-review]

@ZhennanQin could you please rebase your PR and resolve the conflicts?

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Mar 1, 2019
@ZhennanQin ZhennanQin requested a review from szha as a code owner March 14, 2019 06:50
anirudh2290
anirudh2290 approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@anirudh2290 anirudh2290 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ZhennanQin . Nice work! Added minor comments, otherwise LGTM.

src/operator/subgraph/subgraph_property.h Outdated Show resolved Hide resolved
src/operator/subgraph/mkldnn/mkldnn_fc_property.h Outdated Show resolved Hide resolved
src/operator/subgraph/mkldnn/mkldnn_fc_property.h Show resolved Hide resolved
@pengzhao-intel
Copy link
Contributor

@anirudh2290 thanks a lot for the review :)

@reminisce could you help to review again?

reminisce
reminisce approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@reminisce reminisce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on cosmetics. Otherwise LGTM.

src/operator/subgraph/subgraph_property.h Outdated Show resolved Hide resolved
src/operator/subgraph/subgraph_property.h Outdated Show resolved Hide resolved
src/executor/graph_executor.cc Outdated Show resolved Hide resolved
pengzhao-intel
pengzhao-intel approved these changes Mar 23, 2019
View reviewed changes
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

Will merge the PR after the CI pass.

@ZhennanQin
Copy link
Contributor Author

ZhennanQin commented Mar 23, 2019 •
edited
Loading

CI is blocked by #14507 and should be fixed by #14504.

@pengzhao-intel pengzhao-intel merged commit f8a0dbc into apache:master Mar 26, 2019
perdasilva pushed a commit to perdasilva/incubator-mxnet that referenced this pull request Mar 26, 2019
@ZhennanQin @perdasilva
Enhance PartitionGraph (apache#14277)
0595afc 
* Enhance PartitionGraph

* Fix lint

* Fix test

* Run CI

* Change subgraph property register

* Change doc

* Fix name

* Run CI

* Add env var in doc

* Address comments.

* run CI
@pengzhao-intel pengzhao-intel mentioned this pull request Mar 27, 2019
Merged
5 tasks
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@ZhennanQin @vdantu
Enhance PartitionGraph (apache#14277)
227f067 
* Enhance PartitionGraph

* Fix lint

* Fix test

* Run CI

* Change subgraph property register

* Change doc

* Fix name

* Run CI

* Add env var in doc

* Address comments.

* run CI
ZhennanQin added a commit to ZhennanQin/incubator-mxnet that referenced this pull request Apr 3, 2019
@ZhennanQin
Enhance PartitionGraph (apache#14277)
14fe12a 
* Enhance PartitionGraph

* Fix lint

* Fix test

* Run CI

* Change subgraph property register

* Change doc

* Fix name

* Run CI

* Add env var in doc

* Address comments.

* run CI
nswamy pushed a commit that referenced this pull request Apr 5, 2019
@ZhennanQin @nswamy
Enhance PartitionGraph (#14277)
0ab1da2 
* Enhance PartitionGraph

* Fix lint

* Fix test

* Run CI

* Change subgraph property register

* Change doc

* Fix name

* Run CI

* Add env var in doc

* Address comments.

* run CI
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@ZhennanQin
Enhance PartitionGraph (apache#14277)
7d3625f 
* Enhance PartitionGraph

* Fix lint

* Fix test

* Run CI

* Change subgraph property register

* Change doc

* Fix name

* Run CI

* Add env var in doc

* Address comments.

* run CI
@ZhennanQin ZhennanQin deleted the fix_bind branch September 16, 2019 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pengzhao-intel pengzhao-intel pengzhao-intel approved these changes

@reminisce reminisce reminisce approved these changes

@anirudh2290 anirudh2290 anirudh2290 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ZhennanQin @anirudhacharya @pengzhao-intel @anirudh2290 @reminisce @marcoabreu @xinyu-intel