Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix entropy for uint8 #14150

Merged
merged 8 commits into from
Mar 15, 2019
Merged

Fix entropy for uint8 #14150

merged 8 commits into from
Mar 15, 2019

Conversation

ZhennanQin
Copy link
Contributor

Description

Discussed in #13697.

@reminisce @zheng-da @pengzhao-intel @TaoLv

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@ZhennanQin ZhennanQin requested a review from szha as a code owner February 14, 2019 00:41
@ZhennanQin
Copy link
Contributor Author

This is a point fix for uint8 and won't affect GPU accuracy. So test isn't needed.

@ankkhedia
Copy link
Contributor

@ZhennanQin Thanks for your contribution!
@mxnet-label-bot add [pr-awaiting-review, Quantization ]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review Quantization Issues/Feature Requests related to Quantization labels Feb 14, 2019
@vandanavk
Copy link
Contributor

@anirudh2290 is this PR good to go?

@pengzhao-intel
Copy link
Contributor

@ZhennanQin Did we resolve all comments in here and is this the valid PR to be merged?

@ZhennanQin
Copy link
Contributor Author

@pengzhao-intel @anirudh2290 All comments are resolved now. Thanks for the advice. Can we merge it now?

@anirudh2290 anirudh2290 merged commit d1fcda9 into apache:master Mar 15, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@ZhennanQin @vdantu
Fix entropy for uint8 (apache#14150)
c712816 
* Fix entropy for uint8

* Add test

* Update test_quantization.py
nswamy pushed a commit that referenced this pull request Apr 5, 2019
@ZhennanQin @nswamy
Fix entropy for uint8 (#14150)
506bc77 
* Fix entropy for uint8

* Add test

* Update test_quantization.py
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@ZhennanQin
Fix entropy for uint8 (apache#14150)
4960d5a 
* Fix entropy for uint8

* Add test

* Update test_quantization.py
@ZhennanQin ZhennanQin deleted the fix_entropy branch September 16, 2019 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reminisce reminisce reminisce approved these changes

@anirudh2290 anirudh2290 anirudh2290 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review Quantization Issues/Feature Requests related to Quantization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ZhennanQin @ankkhedia @vandanavk @pengzhao-intel @anirudh2290 @reminisce @marcoabreu