This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@vishaalkapoor @marcoabreu could you help take a look? thanks! |
@roywei Thanks for your contribution! @mxnet-label-bot add [pr-awaiting-review, test] |
Nice work. Thanks for getting to the root cause :) LGTM! |
ChaiBapchya
approved these changes
Feb 13, 2019
sandeep-krishnamurthy
approved these changes
Feb 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
* fix nightly * trigger ci
jessr92
pushed a commit
to jessr92/incubator-mxnet
that referenced
this pull request
Feb 19, 2019
* fix nightly * trigger ci
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Mar 4, 2019
* fix nightly * trigger ci
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* fix nightly * trigger ci
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* fix nightly * trigger ci
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a followup on #14119
fixes #14026
In addition of increase shared memory on docker, I reduced the number of workers. It was using 32 workers and created too large shared memory.
Thanks for the help from the Berlin team, I just attended the office hours and was able to reproduce the docker environment and test the fix.
This fix is tested and passed on CI docker using AWS Ubuntu DeepLearning Base AMI on g3.8xlarge
running following test passed:
output:
python 3 test also passed
output:
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Comments