This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
update the scala installation tutorial on intellij #14033
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgk
reviewed
Jan 31, 2019
@@ -324,7 +325,7 @@ log4j.appender.stdout.layout.ConversionPattern=%d{yyyy-MM-dd HH:mm:ss,SSS} [%t] | |||
|
|||
**Step 6.** Build the project: | |||
- To build the project, from the menu choose Build, and then choose Build Project. | |||
|
|||
* Note that if you run into ```bad option: '-make:transitive'```, please follow the [how to solve scalac-error-bad-option-maketransitive](https://stackoverflow.com/questions/35016945/scalac-error-bad-option-maketransitive-on-mvn-package-via-command-line) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What change from the stackoverflow page did you apply to solve the error? Can you either apply it directly to the POM in Step 3 so users following the tutorial don't have to worry about it or copy the solution you found directly into the tutorial?
zachgk
approved these changes
Jan 31, 2019
lanking520
approved these changes
Feb 1, 2019
@mxnet-label-bot add [pr-awaiting-merge] |
piyushghai
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for making these changes :)
aaronmarkham
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
* update the scala installation tutorial on intellij * update the so answer * update the so answer
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* update the scala installation tutorial on intellij * update the so answer * update the so answer
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* update the scala installation tutorial on intellij * update the so answer * update the so answer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the scala installation doc
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
@zachgk @lanking520 @piyushghai @andrewfayres @frankfliu
Comments