This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Python BucketingModule bind() with grad_req = 'add' #13984
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the possibility of changing the
grad_req
ofBucketingModule
to values other than the default'write'
in the Python interface.Previously,
grad_req
would default to'write'
every time the bucket is switched causing gradient accumulation not to work whenever a non-default bucket key was used.Also a new unit-test case has been added to test 1. the correct binding of sub-modules and 2. gradient accumulation with different
grad_req
values.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
grad_req
from bind() call. ,grad_req
for BucketingModule.