[Clojure] examples with opencv4/origami #13813

hellonico · 2019-01-09T07:45:52Z

Description

This PR uses OpenCV/Origami as the image manipulation library.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
Changes are complete (i.e. I finished coding on this PR)
[x ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Basically using library: [origami "4.0.0-2"] with imports:

[opencv4.core :as cv]
[opencv4.utils :as cvu]

Whenever possible.

Comments

anirudhacharya · 2019-01-09T18:25:52Z

@mxnet-label-bot add [pr-awaiting-review]

gigasquid

Great work!

gigasquid · 2019-01-13T14:00:35Z

contrib/clojure-package/examples/gan/src/gan/viz.clj

-              _ (Core/flip img result (int 0))]
-          result)
-        img))))
+              (cv/>> (new-mat height width CV_8UC1) (byte-array raw-data)))]


neat threading :)

gigasquid · 2019-01-13T14:05:07Z

contrib/clojure-package/examples/neural-style/src/neural_style/core.clj

+    (println "The nd image size is:" {:height h :width w})
+    (-> simg 
+      (cv/convert-to! cv/CV_8SC3 0.5) 
+      (cv/add! (cv/new-scalar -103.939 -116.779 -123.68) ) 


Cool - this is a nice way to do this

gigasquid · 2019-01-13T14:06:43Z

contrib/clojure-package/examples/neural-style/src/neural_style/core.clj

+  (let [h (.height simg) w (.width simg)]
+    (println "The nd image size is:" {:height h :width w})
+    (-> simg 
+      (cv/convert-to! cv/CV_8SC3 0.5) 


what does the 0.5 in convert-to! do?

its scaling the bytes to match the new format. (-128 > 128 instead of 0 > 255)

gigasquid · 2019-01-13T14:08:21Z

contrib/clojure-package/examples/pre-trained-models/src/pre_trained_models/predict_image.clj

-                               [(conj rs r) (conj gs g) (conj bs b)]))
-                           [[] [] []]
-                           pixels)]
-    (when show? (img/show image))


Is there a way to show the image to the user if the show? flag is true? imshow?

just added !

gigasquid · 2019-01-13T14:17:52Z

contrib/clojure-package/examples/infer/objectdetector/src/infer/draw.clj

+		[opencv4.core :refer [FONT_HERSHEY_PLAIN imread imwrite new-point put-text! rectangle]]))
+
+(defn black-boxes! [img results]
+    (doseq [


I feel like the formatting is a bit off in this function - I know if varies from editor to editor. There is a tool to keep the style consistent between contributors, (I should run this more often I know :) )

indeed. updated the formatting.

gigasquid · 2019-01-13T14:24:06Z

contrib/clojure-package/examples/neural-style/project.clj

@@ -18,8 +18,8 @@
 (defproject neural-style "0.1.0-SNAPSHOT"


Ran the example - works great!

gigasquid · 2019-01-13T14:33:00Z

contrib/clojure-package/examples/infer/objectdetector/project.clj

  :plugins [[lein-cljfmt "0.5.7"]]
+  :aliases {"sample-detector" ["run" "--" "-m" "models/resnet50_ssd/resnet50_ssd_model" "-i" "images/dog.jpg" "-d" "images/"]}


nice alias - can you please add to the README too?

gigasquid · 2019-01-13T14:34:09Z

contrib/clojure-package/examples/infer/objectdetector/src/infer/objectdetector_example.clj

@@ -106,10 +127,9 @@
                  factory
                  {:contexts [(context/default-context)]})]
    (println "Object detection on a single image")
-    (print-predictions (detect-single-image detector input-image) width height)


Could we also leave the printing of the predictions to the console in as well?

gigasquid · 2019-01-13T14:35:42Z

contrib/clojure-package/examples/infer/objectdetector/src/infer/objectdetector_example.clj


 (defn detect-images-in-dir
  "Detect objects in all jpg images in the directory"
-  [detector input-dir]
+  [detector input-dir output-dir]


Could we make the default output-dir for the example results or image-results?

"results" it is.

gigasquid · 2019-01-13T14:37:35Z

contrib/clojure-package/examples/infer/objectdetector/src/infer/objectdetector_example.clj

@@ -20,6 +20,7 @@
            [org.apache.clojure-mxnet.infer :as infer]
            [org.apache.clojure-mxnet.layout :as layout]
            [clojure.java.io :as io]
+            [infer.draw :as draw]


I ran the example and the drawing of the bounding boxes is fantastic!

Can you please merge this PR with master because the output of the predictions has now changed shape a bit
#13864

Object detection now returns a map
{:class car, :prob 0.99847263, :x-min 0.6097917, :y-min 0.1406818, :x-max 0.8906532, :y-max 0.29426125}

Thanks for pointing out ! Re-Merged with master and fixed.

gigasquid · 2019-01-14T01:14:32Z

Thanks for addressing the feedback so quickly @hellonico 😄
I plan to take one more test drive through it shortly 🏎

gigasquid · 2019-01-16T22:28:20Z

Thanks for all your hard work on making this possible @hellonico - It works great - tested on OSX and Linux 🎆

This reverts commit 754ff76.

hellonico requested a review from gigasquid as a code owner January 9, 2019 07:45

marcoabreu added the pr-awaiting-review PR is waiting for code review label Jan 9, 2019

gigasquid added the Clojure label Jan 10, 2019

hellonico force-pushed the topic/examples-to-origami branch from f726ecf to 8b790f2 Compare January 11, 2019 05:56

hellonico added a commit to hellonico/incubator-mxnet that referenced this pull request Jan 11, 2019

apache#13813 clojure examples with opencv4/origami

8b790f2

gigasquid reviewed Jan 13, 2019

View reviewed changes

hellonico force-pushed the topic/examples-to-origami branch from 8b790f2 to 4cb7d8b Compare January 13, 2019 17:20

hellonico added a commit to hellonico/incubator-mxnet that referenced this pull request Jan 13, 2019

apache#13813 examples with opencv4/origami

4cb7d8b

hellonico force-pushed the topic/examples-to-origami branch from 4cb7d8b to e027290 Compare January 13, 2019 17:25

hellonico added a commit to hellonico/incubator-mxnet that referenced this pull request Jan 13, 2019

apache#13813 examples with opencv4/origami

e027290

gigasquid changed the title ~~[WIP] examples with opencv4/origami~~ [Clojure] examples with opencv4/origami Jan 15, 2019

apache#13813 examples with opencv4/origami

d2035dd

hellonico force-pushed the topic/examples-to-origami branch from e027290 to d2035dd Compare January 16, 2019 07:58

gigasquid merged commit 754ff76 into apache:master Jan 16, 2019

piyushghai added a commit to piyushghai/incubator-mxnet that referenced this pull request Jan 22, 2019

Revert " apache#13813 examples with opencv4/origami (apache#13813)"

848babd

This reverts commit 754ff76.

stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019

apache#13813 examples with opencv4/origami (apache#13813)

5fbe585

haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019

apache#13813 examples with opencv4/origami (apache#13813)

92fe0bf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Clojure] examples with opencv4/origami #13813

[Clojure] examples with opencv4/origami #13813

hellonico commented Jan 9, 2019

anirudhacharya commented Jan 9, 2019

gigasquid left a comment

gigasquid Jan 13, 2019

gigasquid Jan 13, 2019

gigasquid Jan 13, 2019

hellonico Jan 13, 2019

gigasquid Jan 13, 2019

hellonico Jan 13, 2019

gigasquid Jan 13, 2019

hellonico Jan 13, 2019

gigasquid Jan 13, 2019

gigasquid Jan 13, 2019

hellonico Jan 13, 2019

gigasquid Jan 13, 2019

hellonico Jan 13, 2019

gigasquid Jan 13, 2019

hellonico Jan 13, 2019

gigasquid Jan 13, 2019

hellonico Jan 13, 2019

gigasquid commented Jan 14, 2019

gigasquid commented Jan 16, 2019

		:plugins [[lein-cljfmt "0.5.7"]]
		:aliases {"sample-detector" ["run" "--" "-m" "models/resnet50_ssd/resnet50_ssd_model" "-i" "images/dog.jpg" "-d" "images/"]}

[Clojure] examples with opencv4/origami #13813

[Clojure] examples with opencv4/origami #13813

Conversation

hellonico commented Jan 9, 2019

Description

Checklist

Essentials

Changes

Comments

anirudhacharya commented Jan 9, 2019

gigasquid left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gigasquid commented Jan 14, 2019

gigasquid commented Jan 16, 2019