-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Update LICENSE File with subcomponents #13808
Conversation
@mxnet-label-bot add [Licenses] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright to me.
@@ -1,3 +1,20 @@ | |||
# Licensed to the Apache Software Foundation (ASF) under one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't even think we use this file...
@frankfliu , could you please also take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Update LICENSE File with subcomponents * Fix JavaScript licenses
Great work @zachgk - thank you! |
@zachgk should this be cherry picked into 1.4.x? |
We need the following to be sync'd up across master and 1.4.x:
|
@lupesko This should be cherry-picked and I added a PR for it at #13856.
In summary, the only change still needed should be PR #13856 |
* Update LICENSE File with subcomponents (apache#13808) * Update LICENSE File with subcomponents * Fix JavaScript licenses * Add copyrights for third party licenses to license file (apache#13851) * Remove R-package from LICENSE * Update googletest due to licensing
* Update LICENSE File with subcomponents * Fix JavaScript licenses
Description
This PR updates the main LICENSE file by adding missing subcomponents of the project, combining the BSD licenses to their own section, and removing several subcomponents that were deleted.
It updates the two whitelists for automatic license checks by removing files that should not be there (this may involve adding the appropriate headers to files). Explanations were also added for each element in the license_header.py whitelist. Lastly, automatic checking for clojure and pyx files was also enabled.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.