This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-1180] Java Image API #13807
Merged
[MXNET-1180] Java Image API #13807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add [pr-awaiting-review, Java] |
marcoabreu
added
Java
lanking520
force-pushed
the
javaimage
branch
2 times, most recently
from
70cadec to
4936b6a
Compare
lanking520
changed the title
piyushghai
reviewed
Jan 15, 2019
zachgk
reviewed
Jan 15, 2019
piyushghai
reviewed
Jan 16, 2019
scala-package/core/src/test/java/org/apache/mxnet/javaapi/ImageTest.java
Outdated
Show resolved
Hide resolved
piyushghai
reviewed
Jan 16, 2019
| "--model-path-prefix", modelPathPrefix, | ||
| "--input-image", inputImagePath | ||
| }; | ||
| example.main(args); |
There was a problem hiding this comment.
Is the test to simply run the example code ?
There was a problem hiding this comment.
Yes, the example test is to verify the example is still working...
zachgk
suggested changes
Jan 17, 2019
| * @return org.apache.mxnet.NDArray | ||
| */ | ||
| def imResize(src: NDArray, w: Int, h: Int, interp: Integer): NDArray = { | ||
| val interpVal = if (interp == null) None else Some(interp.intValue()) |
There was a problem hiding this comment.
You can just use Option(interp.intValue())
There was a problem hiding this comment.
This will cause a null pointer exception, since users may send null in
| @@ -15,6 +15,7 @@ | |||
|
|
|||
| <properties> | |||
| <skipTests>true</skipTests> | |||
| <skipJavaTests>${skipTests}</skipJavaTests> | |||
There was a problem hiding this comment.
What is this for? I don't think it is valid in maven to set one property based on another property and it is just set to false in modules which have java tests to run
There was a problem hiding this comment.
This keeps control of a Junit test is going to run or not, by default it is set to be false. In fact, this is working...
piyushghai
reviewed
Jan 17, 2019
scala-package/core/src/main/scala/org/apache/mxnet/javaapi/Image.scala
Outdated
Show resolved
Hide resolved
|
@sandeep-krishnamurthy could you please give a review? |
yzhliu
approved these changes
Jan 31, 2019
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
* add java example * add test and change PredictorExample * add image change * Add minor fixes * add License * add predictor Example tests * fix the issue with JUnit test * Satisfy Lint God ʕ •ᴥ•ʔ * update the pom file config * update documentation * add simplified methods
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* add java example * add test and change PredictorExample * add image change * Add minor fixes * add License * add predictor Example tests * fix the issue with JUnit test * Satisfy Lint God ʕ •ᴥ•ʔ * update the pom file config * update documentation * add simplified methods
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* add java example * add test and change PredictorExample * add image change * Add minor fixes * add License * add predictor Example tests * fix the issue with JUnit test * Satisfy Lint God ʕ •ᴥ•ʔ * update the pom file config * update documentation * add simplified methods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As title described, add Scala Image API to Java...
@zachgk @piyushghai @andrewfayres
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.