This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fix omp bug in multibox_detection to avoid accuracy variance in ssd #13622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinyu-intel
changed the title
Fix SSD accuracy variance
Fix omp bug in multibox_detection to avoid accuracy variance in ssd
Dec 13, 2018
@apeforest @yuxihu could you help take a review? |
TaoLv
approved these changes
Dec 13, 2018
@mxnet-label-bot add[Backend, pr-awaiting-review] |
marcoabreu
added
Backend
Issues related to the backend of MXNet
pr-awaiting-review
PR is waiting for code review
labels
Dec 14, 2018
@xinyu-intel please also paste the performance change of SSD model. If it's negligible, I think this PR is good to go. Thank you. |
P40:
Skylake Before fix:
Skylake After fix
|
TaoLv
approved these changes
Dec 17, 2018
Thank you for the fix. |
KellenSunderland
added a commit
that referenced
this pull request
Dec 17, 2018
This reverts commit 655f1c6.
aaronmarkham
pushed a commit
that referenced
this pull request
Dec 18, 2018
mseth10
pushed a commit
to mseth10/incubator-mxnet
that referenced
this pull request
Dec 18, 2018
mseth10
pushed a commit
to mseth10/incubator-mxnet
that referenced
this pull request
Dec 18, 2018
* Revert "remove omp which can cause ssd accuracy variance (apache#13622)" This reverts commit 655f1c6. * Revert "Fix Jetson compilation (apache#13532)" This reverts commit 48e25c4.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to fix omp bug in
multibox_detection
to avoid accuracy variance of SSD topology.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
@pengzhao-intel @TaoLv