-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-1251] Basic configuration to do static-linking #13621
Conversation
Any specific reason we aim for Ubuntu 14? Ubuntu 18 has already been released |
@marcoabreu As far as I know. |
ci/publish/ubuntu_build_base.sh
Outdated
--slave /usr/bin/g++ g++ /usr/bin/g++-4.8 | ||
update-alternatives --config gcc | ||
# Java specific | ||
apt-get install -y openjdk-8-jdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend using the maven3 ppa (sudo add-apt-repository ppa:andrei-pozolotin/maven3) and combining all of the apt-get installs into one call. Also just run one apt-get update after all of the ppa additions and use "set -ex"
Yeah but then we have to maintain two systems. RHEL is known to always be behind due to their strict support, but that shouldn't limit us for support of other operating systems. Would be great if you could separate that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split RHEL and Debian based pipelines
@marcoabreu This is the publish configuration that works for all different platforms and this will not be used in all the rest CIs for testing. The optimal goal is using one configuration to create a About the RHEL and Debian diff. Firstly the published stuff is all the same no matter on RHEL or Debian and can be run on either. Introducing a different publish pipeline for these two in this case is not necessary as it introduce more maintainance nightmare. |
Thanks for the insight, Qing! Can the binaries you create with this script in that form be loaded into ubuntu16/18 and other systems that have later versions? If yes, then I'm fine with that approach :) |
The answer is yes. In fact, @frankfliu has already working on producing the Dockerfile from this script that works for 16.04 with the publish pipeline. However it depends on the setup of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright thanks for your explanation. Please feel free to go ahead then.
You might want to add a comment in the code which packages specifically have to stay at a certain version and that they are chosen as the smallest common denominator
08c21ff
to
dec9cca
Compare
@mxnet-label-bot add[Build, pr-awaiting-merge] |
* Basic configuration to do static-linking * update build script and place it in the install part * clean up the code further * revert maven into build-from-source * add curl to deps
* Basic configuration to do static-linking * update build script and place it in the install part * clean up the code further * revert maven into build-from-source * add curl to deps
* Basic configuration to do static-linking * update build script and place it in the install part * clean up the code further * revert maven into build-from-source * add curl to deps
* Basic configuration to do static-linking * update build script and place it in the install part * clean up the code further * revert maven into build-from-source * add curl to deps
* Basic configuration to do static-linking * update build script and place it in the install part * clean up the code further * revert maven into build-from-source * add curl to deps
* Basic configuration to do static-linking * update build script and place it in the install part * clean up the code further * revert maven into build-from-source * add curl to deps
Description
For Ubuntu 14.04 base build to install all dependencies.
@szha @zachgk
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.