Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Updated dockerfiles to get the dockcross images from mxnetcipinned #13562

Merged
merged 6 commits into from
Feb 14, 2019
Merged

Updated dockerfiles to get the dockcross images from mxnetcipinned #13562

merged 6 commits into from
Feb 14, 2019

Conversation

jlcontreras
Copy link
Contributor

Updating the dockerfiles, as the dockcross images moved to mxnetcipinned on Docker Hub.
https://hub.docker.com/u/mxnetcipinned/

@jlcontreras jlcontreras closed this Dec 6, 2018
@jlcontreras jlcontreras reopened this Dec 6, 2018
@larroy
Copy link
Contributor

larroy commented Dec 6, 2018

what is that docker repo and what's the difference with the previous? Does this also update cuda? I find this PR confusing.

@nswamy nswamy added the pr-awaiting-review PR is waiting for code review label Dec 7, 2018
@jlcontreras
Copy link
Contributor Author

The dockcross images are no longer in the old repo (mxnetci), they moved to mxnetcipinned, but as far as I know they should be the same.

The cuda update was there by mistake, removed.

Also added your changes from #13532 to fix Jetson builds.

@Roshrini
Copy link
Member

@jlcontreras Can you please check the CI failure? Thanks!

@Roshrini
Copy link
Member

Roshrini commented Jan 2, 2019

@mxnet-label-bot Update [pr-awaiting-response]

@marcoabreu marcoabreu added pr-awaiting-response PR is reviewed and waiting for contributor to respond and removed pr-awaiting-review PR is waiting for code review labels Jan 2, 2019
@anirudhacharya
Copy link
Member

@jlcontreras please rebase your PR

@jlcontreras
Copy link
Contributor Author

Why is the rebase needed? AFAIU this already points to the head of v1.3.x. Jetson still needs fixing though, but I'm not sure if I'll have time for it in the coming weeks.

@sandeep-krishnamurthy
Copy link
Contributor

@marcoabreu - Can this PR be merged?

@vandanavk
Copy link
Contributor

@mxnet-label-bot update [pr-awaiting-testing]

@marcoabreu marcoabreu added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-response PR is reviewed and waiting for contributor to respond labels Feb 8, 2019
@larroy
Copy link
Contributor

larroy commented Feb 11, 2019

LGTM

@jlcontreras
Copy link
Contributor Author

Had to add a minor fix to one of the tests so the PR passes CI

lebeg
lebeg approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@lebeg lebeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

This was referenced Feb 14, 2019
Closed
Merged
@marcoabreu
Copy link
Contributor

Merging since the deploy failure is unrelated and will be addressed in #14163 - we have a clash here and have to merge one first.

@marcoabreu marcoabreu merged commit 3623af4 into apache:v1.3.x Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcoabreu marcoabreu marcoabreu approved these changes

@lebeg lebeg lebeg approved these changes

Assignees
No one assigned
Labels
pr-awaiting-testing PR is reviewed and waiting CI build and test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jlcontreras @larroy @Roshrini @anirudhacharya @sandeep-krishnamurthy @vandanavk @marcoabreu @lebeg @nswamy