Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Adadelta optimizer test #13443

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Adadelta optimizer test #13443

merged 2 commits into from
Dec 4, 2018

Conversation

anirudhacharya
Copy link
Member

@anirudhacharya anirudhacharya commented Nov 28, 2018 •
edited
Loading

Description

Adadelta optimizer test

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • FTML doc fix
  • test for adadelta

@anirudhacharya anirudhacharya requested a review from szha as a code owner November 28, 2018 21:15
@vandanavk
Copy link
Contributor

vandanavk commented Nov 28, 2018 •
edited
Loading

@mxnet-label-bot add [Test, pr-awaiting-review]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review Test labels Nov 28, 2018
larroy
larroy reviewed Nov 29, 2018
View reviewed changes
Copy link
Contributor

@larroy larroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, just 2 comments.

tests/python/unittest/test_optimizer.py Show resolved Hide resolved
tests/python/unittest/test_optimizer.py Outdated Show resolved Hide resolved
@anirudhacharya anirudhacharya mentioned this pull request Nov 29, 2018
Merged
3 tasks
sandeep-krishnamurthy
sandeep-krishnamurthy reviewed Dec 4, 2018
View reviewed changes
tests/python/unittest/test_optimizer.py
rg_options = [{}, {'rescale_grad': 0.14}, {'rescale_grad': 0.8}]
wd_options = [{}, {'wd': 0.0}]
for dtype in [np.float16, np.float32]:
for params in itertools.product(rho_options, eps_options, cg_options,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very clean and nice!
Thanks @larroy and @anirudhacharya

sandeep-krishnamurthy
sandeep-krishnamurthy approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Pedro - I see your feedback is addressed here. I am going ahead with merging it.

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 06245b1 into apache:master Dec 4, 2018
@larroy
Copy link
Contributor

larroy commented Dec 4, 2018

yes, good job.

zhaoyao73 pushed a commit to zhaoyao73/incubator-mxnet that referenced this pull request Dec 13, 2018
@anirudhacharya @zhaoyao73
Adadelta optimizer test (apache#13443)
a12d8d6 
* adadelta test

* comments
@anirudhacharya anirudhacharya deleted the pyAdaDelta branch January 16, 2019 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@larroy larroy larroy left review comments

@sandeep-krishnamurthy sandeep-krishnamurthy sandeep-krishnamurthy approved these changes

@szha szha Awaiting requested review from szha

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anirudhacharya @vandanavk @larroy @sandeep-krishnamurthy @marcoabreu