This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Add imresize and copyMakeBorder to mx.image #13357
Merged
sandeep-krishnamurthy
merged 3 commits into
apache:master
from
anirudhacharya:resizeDocs
Dec 11, 2018
Merged
Add imresize and copyMakeBorder to mx.image #13357
sandeep-krishnamurthy
merged 3 commits into
apache:master
from
anirudhacharya:resizeDocs
Dec 11, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyushghai
reviewed
Nov 21, 2018
@mxnet-label-bot add [pr-awaiting-review] |
anirudhacharya
force-pushed
the
resizeDocs
branch
2 times, most recently
from
November 23, 2018 01:23
2838d22
to
efebff1
Compare
stu1130
reviewed
Nov 23, 2018
stu1130
reviewed
Nov 23, 2018
anirudhacharya
force-pushed
the
resizeDocs
branch
from
November 27, 2018 04:26
efebff1
to
c260411
Compare
vandanavk
reviewed
Nov 29, 2018
@frankfliu @aaronmarkham for review |
5 tasks
anirudhacharya
force-pushed
the
resizeDocs
branch
from
December 3, 2018 13:25
c260411
to
8947348
Compare
@anirudhacharya could you address the CI failure? I will use the resize you exported to test my operator Thanks! |
anirudhacharya
force-pushed
the
resizeDocs
branch
from
December 10, 2018 21:52
8947348
to
7690fc9
Compare
stu1130
approved these changes
Dec 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sandeep-krishnamurthy
approved these changes
Dec 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
zhaoyao73
added a commit
to zhaoyao73/incubator-mxnet
that referenced
this pull request
Dec 13, 2018
* upstream/master: [MXNET-1253] fix control_flow_op (apache#13555) Add imresize and copyMakeBorder to mx.image (apache#13357)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Though mx.image.imresize and mx.image.copyMakeBorder is currently available for external use, it does not show up in the docs because it was hidden behind an internal function call.
reference - #12831 (comment)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.