-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the licensing issue!
@anirudhacharya The R-Package folder also contains a LICENSE file, which is not an Apache2.0 license. How are we addressing it? |
@mxnet-label-bot [pr-awaiting-review] |
Thanks @anirudhacharya |
Should we just remove that license and after adding Apache license to every file. |
6167827
to
78946e6
Compare
@ankkhedia why should we remove the file? scala, clojure and cpp package also have LICENSE files. |
But python don't have. I don't mind it having over there just that if adding headers to all the files suffices do we need an extra file? |
@ankkhedia - I do not have a strong opinion but it is good to have in the base package folder. |
* add license headers to R-package * license file and demos folder
Description
Add license headers to all files in R-package.
Current MXNet release instructions requires all files in the R-package to be removed until licensing issues are resolved, before we build the tar file. This PR is to resolve those licensing issues.
Comments