This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spatial transformer op produced incorrect results with
USE_CUDA=ON
USE_CUDNN=OFF
till now. This was due to separate threads writing to the same global memory locations causing undefined behavior.Replaced all such writes with
atomicAdd
. I have also reenabled the disabled test:test_stn
.Removed assertion_error param for
assert_raises_cudnn_disabled
.This fixes #11568
@tornadomeet @marcoabreu
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.