Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-473] Fix for dist_sync_kvstore and test_operator.test_op_roi_align #11058

Merged
merged 2 commits into from
May 25, 2018

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented May 24, 2018

Description

Fix for #11057 #11064

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Change the type switch in elemwise_add/sub between dense and rsp

Comments

@eric-haibin-lin

@haojin2 haojin2 force-pushed the fix_elemwise_dns_rsp_dtype branch from 2c770bf to 5797fb6 Compare May 25, 2018 18:29
@haojin2
Copy link
Contributor Author

haojin2 commented May 25, 2018

@eric-haibin-lin

@haojin2
Copy link
Contributor Author

haojin2 commented May 25, 2018

@rahul003 this should fix the issue of dist_sync_kvstore

@eric-haibin-lin eric-haibin-lin changed the title [MXNET-473] Fix for dist_sync_kvstore [MXNET-473] Fix for dist_sync_kvstore and test_operator.test_op_roi_align May 25, 2018
@eric-haibin-lin eric-haibin-lin merged commit d528453 into apache:master May 25, 2018
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request May 29, 2018
[MXNET-473] Fix for dist_sync_kvstore and test_operator.test_op_roi_align
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
[MXNET-473] Fix for dist_sync_kvstore and test_operator.test_op_roi_align
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
[MXNET-473] Fix for dist_sync_kvstore and test_operator.test_op_roi_align
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants