This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-173]fix acc metric shape miss match #10446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roywei
changed the title
[WIP][MXNET-173]fix acc metric shape miss match
[MXNET-173]fix acc metric shape miss match
Apr 6, 2018
roywei
force-pushed
the
metric_shape_miss_match
branch
2 times, most recently
from
April 8, 2018 22:48
4232318
to
bf7d7db
Compare
@reminisce @sandeep-krishnamurthy Can you review? |
@hetong007 could you help to take a look at this in metric.py? Thanks! |
@roywei can you please add test for it? I see you checked "All changes have test coverage" but find no related change. |
roywei
force-pushed
the
metric_shape_miss_match
branch
from
April 10, 2018 19:28
bf7d7db
to
0944d6d
Compare
@hetong007 updated with unit test |
sandeep-krishnamurthy
approved these changes
Apr 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
roywei
force-pushed
the
metric_shape_miss_match
branch
from
April 10, 2018 20:52
7329675
to
7c0f54a
Compare
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* fix acc metric shape miss match * add unit test * fix style * fix python2 division
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* fix acc metric shape miss match * add unit test * fix style * fix python2 division
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix issue #2116
This only happens when label is provided in 2D array through custom data iterator, it was not affecting major use cases because most of the time, the labels are provided in 1D or built in iterators.
The root cause is label and pred_label in 'acc' metric have different shapes during check_label_shapes. It's similar to 'ce' metric which works fine because it ravel the label shape before check.
Flatten label and pred_label for equal comparison, and 'acc' needed flattened result anyway
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments