This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-160] Fix for issue 9062 #10413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eric-haibin-lin @rahul003 @reminisce @anirudh2290 This is bug fix for #9062, please give a review if you have a minute. Thanks! |
anirudh2290
reviewed
Apr 5, 2018
tests/python/unittest/test_random.py
Outdated
| freq = np.bincount(y[i,:], minlength=5)/np.float32(samples)*x[i,:].sum() | ||
| mx.test_utils.assert_almost_equal(freq, x[i], rtol=0.20) | ||
| rprob = x[i][y[i]]/x[i].sum() | ||
| mx.test_utils.assert_almost_equal(np.log(rprob), prob.asnumpy()[i]) |
There was a problem hiding this comment.
should we provide specific atol ?
There was a problem hiding this comment.
Is the default not 1e-20?
There was a problem hiding this comment.
The current test can always pass, I guess the default 1e-20 value should be okay?
There was a problem hiding this comment.
Should provide atol to avoid failure when comparing two numbers that are close to zero.
tests/python/unittest/test_random.py
Outdated
| real_dx = np.zeros((5,)) | ||
| for j in range(samples): | ||
| real_dx[y[i][j]] += 5.0 / rprob[j] | ||
| mx.test_utils.assert_almost_equal(real_dx, dx[i, :], rtol=1e-4) |
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* fix typo in sample_multinomial_op.h (issue apache#9062) * add test case for 1D prob input case
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* fix typo in sample_multinomial_op.h (issue apache#9062) * add test case for 1D prob input case
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix for issue #9062
Checklist
Essentials
Changes