Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MTOOLCHAINS-50] Update parent pom to 41 #19

Merged
merged 5 commits into from
Feb 28, 2024
Merged

[MTOOLCHAINS-50] Update parent pom to 41 #19

merged 5 commits into from
Feb 28, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Feb 27, 2024 •
edited by gnodet
Loading

JIRA issue: MTOOLCHAINS-50

@elharo
Copy link
Contributor Author

elharo commented Feb 27, 2024

Nope. something seems off with the CI config:

Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default of goal com.diffplug.spotless:spotless-maven-plugin:2.40.0:check failed: Unable to load the mojo 'check' in the plugin 'com.diffplug.spotless:spotless-maven-plugin:2.40.0' due to an API incompatibility: org.codehaus.plexus.component.repository.exception.ComponentLookupException: com/diffplug/spotless/maven/SpotlessCheckMojo has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

@elharo elharo marked this pull request as draft February 27, 2024 14:51
@gnodet
Copy link
Contributor

gnodet commented Feb 27, 2024 •
edited
Loading

Nope. something seems off with the CI config:

Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default of goal com.diffplug.spotless:spotless-maven-plugin:2.40.0:check failed: Unable to load the mojo 'check' in the plugin 'com.diffplug.spotless:spotless-maven-plugin:2.40.0' due to an API incompatibility: org.codehaus.plexus.component.repository.exception.ComponentLookupException: com/diffplug/spotless/maven/SpotlessCheckMojo has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

I think this requires JDK 11 or 17 at build time and should target JDK 8 at runtime.

@elharo
Copy link
Contributor Author

elharo commented Feb 27, 2024

55 is Java 11, I think

@elharo elharo marked this pull request as ready for review February 28, 2024 12:13
@elharo elharo requested a review from gnodet February 28, 2024 12:13
@gnodet gnodet changed the title update parent pom to 41 Update parent pom to 41 Feb 28, 2024
@gnodet gnodet changed the title Update parent pom to 41 [MTOOLCHAINS-50] Update parent pom to 41 Feb 28, 2024
@gnodet gnodet added this to the 3.2.0 milestone Feb 28, 2024
@gnodet
Copy link
Contributor

gnodet commented Feb 28, 2024

I'm merging this one as it blocks other PRs.

@gnodet gnodet merged commit 897b708 into master Feb 28, 2024
48 checks passed
@asfgit asfgit deleted the 41 branch August 18, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnodet gnodet gnodet approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elharo @gnodet @olamy