Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task logger #676

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Task logger #676

merged 3 commits into from
Mar 7, 2023

Conversation

henrysun007
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

#669

The task logger part. Platform logging will be in another PR in a while.

Type of change (select or add applied and delete the others)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just sync with upstream third-party crates

How has this been tested?

Checklist

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the tests pass (see CI results).
  • Make sure your code lints/format.

@henrysun007 henrysun007 force-pushed the task-log branch 3 times, most recently from beb7361 to 27f8925 Compare February 8, 2023 04:00
@henrysun007 henrysun007 requested a review from mssun February 10, 2023 01:25
@mssun
Copy link
Member

mssun commented Feb 15, 2023

The original design is to separate executors with other components to make it more flexible. In this implementation, if I understand correctly, executors are talking to the storage directly. Why not return the logs with the function return value instead?

@henrysun007
Copy link
Contributor Author

henrysun007 commented Feb 15, 2023

Keeping the logs persistent is good for audit. The log is more a supplement to TaskState that is persistent in the storage service than just a diagnosis tool for developers here. Besides, the log content may be large so it is not very suitable as part of the result. However, as you have already been used to the result way in the cleanroom branch, we can use it in the master. Large log scenarios can be handled in the future.

@henrysun007 henrysun007 force-pushed the task-log branch 7 times, most recently from d929742 to 99983c6 Compare March 3, 2023 07:39
@henrysun007 henrysun007 merged commit 27cf49b into apache:master Mar 7, 2023
@henrysun007 henrysun007 deleted the task-log branch March 7, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants