Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better task state error and fix cancel error issue in the example #637

Merged
merged 3 commits into from
Mar 19, 2022
Merged

Better task state error and fix cancel error issue in the example #637

merged 3 commits into from
Mar 19, 2022

Conversation

mssun
Copy link
Member

@mssun mssun commented Mar 18, 2022

Description

Better task state error and fix cancel error issue in the example.

Type of change (select or add applied and delete the others)

  • Bug fix

How has this been tested?

CI: https://ci.mesalock-linux.org/mssun/incubator-teaclave/161

Checklist

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the tests pass (see CI results).
  • Make sure your code lints/format.

@mssun mssun requested a review from ya0guang March 18, 2022 21:55
AI-Memory
AI-Memory approved these changes Mar 19, 2022
View reviewed changes
Copy link
Contributor

@AI-Memory AI-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1, thanks.

@mssun mssun merged commit 816c0f7 into apache:master Mar 19, 2022
@mssun mssun deleted the fix-cancel-error branch March 19, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AI-Memory AI-Memory AI-Memory approved these changes

@ya0guang ya0guang Awaiting requested review from ya0guang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mssun @AI-Memory