optimize: support the nacos application name property #5783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, the client will subscribe to the Seata server and the application name will be unknown apache#4448
…, the client will subscribe to the Seata server and the application name will be unknown apache#4448
funky-eyes
reviewed
Aug 16, 2023
| @@ -79,6 +79,7 @@ seata: | |||
| username: | |||
| password: | |||
| context-path: | |||
| client-application: ${spring.application.name} | |||
There was a problem hiding this comment.
这个配置应该是只有client用吧，我理解错了
There was a problem hiding this comment.
这个配置应该是只有client用吧，我理解错了
我修改一下，提交
| @@ -129,6 +129,7 @@ seata.registry.nacos.namespace= | |||
| seata.registry.nacos.username= | |||
| seata.registry.nacos.password= | |||
| seata.registry.nacos.contextPath= | |||
| seata.registry.nacos.clientApplication=${spring.application.name} | |||
There was a problem hiding this comment.
client增加这个配置后，应该是不影响服务发现的吧，只是订阅者的一个身份登记？
There was a problem hiding this comment.
client增加这个配置后，应该是不影响服务发现的吧，只是订阅者的一个身份登记？
不影响，只是订阅者的一个身份登记
…, the client will subscribe to the Seata server and the application name will be unknown apache#4448
slievrly
changed the title
slievrly
pushed a commit
to slievrly/fescar
that referenced
this pull request
Aug 30, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, the client will subscribe to the Seata server and the application name will be unknown #4448
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews